Add boost.assign 1.83.0.bcr.1 #6543
Conversation
|
@bazel-io skip_check unstable_url |
|
Hello @cdelguercio, modules you maintain (boost.assign) have been updated in this PR. |
|
Hello @Vertexwahn, modules you maintain (boost.assign, boost.timer) have been updated in this PR. |
|
Hello @vtsao-openai, modules you maintain (boost.timer) have been updated in this PR. |
bazel-io
added
the
skip-url-stability-check
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds version 1.83.0.bcr.1 for both boost.assign and boost.timer to the Bazel Central Registry. The changes for boost.timer correctly include test targets. My review has identified a few issues that need to be addressed to ensure correctness and maintainability. For boost.assign, a critical dependency is missing, and a test dependency should be marked as a development dependency. For boost.timer, several test-only dependencies also need to be marked as development dependencies. Please see the detailed comments for specific suggestions.
| deps = [ | ||
| "@boost.array", | ||
| "@boost.config", | ||
| "@boost.core", | ||
| "@boost.move", | ||
| "@boost.preprocessor", | ||
| "@boost.ptr_container", | ||
| "@boost.range", | ||
| "@boost.static_assert", | ||
| "@boost.throw_exception", | ||
| "@boost.tuple", | ||
| "@boost.type_traits", | ||
| ], |
There was a problem hiding this comment.
The cc_library for boost.assign is missing a dependency on @boost.multi_index. According to the Boost documentation, boost.assign depends on boost.multi_index. Please add it to the deps list to ensure the module builds correctly for consumers.
deps = [
"@boost.array",
"@boost.config",
"@boost.core",
"@boost.move",
"@boost.multi_index",
"@boost.preprocessor",
"@boost.ptr_container",
"@boost.range",
"@boost.static_assert",
"@boost.throw_exception",
"@boost.tuple",
"@boost.type_traits",
],
| bazel_dep(name = "boost.ptr_container", version = "1.83.0.bcr.1") | ||
| bazel_dep(name = "boost.range", version = "1.83.0.bcr.1") | ||
| bazel_dep(name = "boost.static_assert", version = "1.83.0.bcr.1") | ||
| bazel_dep(name = "boost.test", version = "1.83.0.bcr.1") |
There was a problem hiding this comment.
The dependency on boost.test is for running tests and is not a required dependency for the library itself. It should be marked as a development dependency by adding dev_dependency = True. This prevents downstream users from unnecessarily fetching test-only dependencies.
| bazel_dep(name = "boost.test", version = "1.83.0.bcr.1") | |
| bazel_dep(name = "boost.test", version = "1.83.0.bcr.1", dev_dependency = True) |
| bazel_dep(name = "boost.chrono", version = "1.83.0.bcr.1") | ||
| bazel_dep(name = "boost.core", version = "1.83.0.bcr.1") | ||
| bazel_dep(name = "boost.detail", version = "1.83.0.bcr.1") |
There was a problem hiding this comment.
The dependencies boost.chrono, boost.core, and boost.detail are only used for tests, as indicated by the comment and their usage in overlay/BUILD.bazel. They should be marked as development dependencies by adding dev_dependency = True to each. This prevents downstream users from unnecessarily fetching test-only dependencies.
| bazel_dep(name = "boost.chrono", version = "1.83.0.bcr.1") | |
| bazel_dep(name = "boost.core", version = "1.83.0.bcr.1") | |
| bazel_dep(name = "boost.detail", version = "1.83.0.bcr.1") | |
| bazel_dep(name = "boost.chrono", version = "1.83.0.bcr.1", dev_dependency = True) | |
| bazel_dep(name = "boost.core", version = "1.83.0.bcr.1", dev_dependency = True) | |
| bazel_dep(name = "boost.detail", version = "1.83.0.bcr.1", dev_dependency = True) |
bazel-io
left a comment
bazel-io
left a comment
There was a problem hiding this comment.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
Wyverald
added
the
presubmit-auto-run
4 participants
Following structure added in 82895ad without using symlink for MODULE.bazel (#6440).
Adjusted according to other boost.* 1.83.0.bcr.1 targets:
Adding @bazel-io skip_check unstable_url as it doesn't have a stable url.
Ran and applied modifications produced by: